lyne7-sc commented on code in PR #25472:
URL: https://github.com/apache/datafusion/pull/25472#discussion_r4063429064
##########
datafusion/physical-plan/src/windows/mod.rs:
##########
@@ -295,7 +295,13 @@ impl StandardWindowFunctionExpr for WindowUDFExpr {
}
fn limit_effect(&self) -> LimitEffect {
- self.fun.inner().limit_effect(self.args.as_slice())
+ if self.ignore_nulls {
Review Comment:
Updated this to preserve `None` and only convert `Relative/Absolute` to
`Unknown` for `IGNORE NULLS`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
