comphead commented on code in PR #12127:
URL: https://github.com/apache/datafusion/pull/12127#discussion_r1729181100
##########
datafusion/physical-plan/src/aggregates/row_hash.rs:
##########
@@ -76,35 +76,43 @@ use super::AggregateExec;
/// This encapsulates the spilling state
struct SpillState {
- /// If data has previously been spilled, the locations of the
- /// spill files (in Arrow IPC format)
- spills: Vec<RefCountedTempFile>,
-
+ /*
======================================================================== */
+ // PROPERTIES:
+ // These fields are initialized at the start and remain constant throughout
+ // the execution.
+ /*
======================================================================== */
/// Sorting expression for spilling batches
spill_expr: Vec<PhysicalSortExpr>,
/// Schema for spilling batches
spill_schema: SchemaRef,
- /// true when streaming merge is in progress
- is_stream_merging: bool,
-
/// aggregate_arguments for merging spilled data
merging_aggregate_arguments: Vec<Vec<Arc<dyn PhysicalExpr>>>,
/// GROUP BY expressions for merging spilled data
merging_group_by: PhysicalGroupBy,
+
+ /*
======================================================================== */
Review Comment:
I dont remember we use this kind of format. I would probably stick to a
single format across the project. Or if we feel the format can be improved lets
do it everywhere and add the notes to the contributing guide
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
