alamb commented on PR #2527: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/2527#issuecomment-5764982038
> > I think the gate should also be about false positives (not just true negatives) > > What do you mean by false positives? I mean the chance of the fuzz test failing on a PR that did not cause whatever problem the fuzzer found. I think if we run non deterministic tests on PRs we are going to inject some noise into the process -- I would recommend against it if at all possible (at least until we have some confidence that the fuzz test is mostly successful -- e.g. run it for a week or more every day and not find anything new) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
