sunchao commented on code in PR #6089: URL: https://github.com/apache/datafusion-comet/pull/6089#discussion_r4066480001
########## docs/source/about/versioning_policy.md: ########## @@ -71,6 +76,46 @@ change in any release: fall back to Spark. An expression that ran natively in one release may fall back in the next, and vice versa. The results stay the same; only the speed changes. +### Testing and Internal Configurations Are Exempt + +Two kinds of configuration key sit outside this policy, and one rule identifies both: **a key is +covered only if the [configuration reference](../user-guide/latest/configs.md) lists it outside the +Development & Testing Settings table.** Everything the reference publishes as a production setting +is guaranteed; nothing else is. Review Comment: ### Correctness **[P2] Preserve documented expression opt-ins in the compatibility surface** Could the exemption be defined by an explicit `testing` category or `internal()` designation, while retaining public keys documented outside `configs.md`? For example, `spark.comet.expression.RLike.allowIncompatible` is documented in the compatibility guide and read by `CometConf.isExprAllowIncompat`, but it has no `ConfigEntry` and is absent from the generated configuration table. `GenerateDocs` emits per-expression `.enabled` keys there and emits native opt-ins on the compatibility pages instead. This rule therefore exempts an existing user-facing config family that is neither testing nor internal, permitting its keys/defaults to change without the normal compatibility path. The same exhaustive statement at `configs.md:83-85` needs to use the narrower definition too. Deprecated public aliases are also omitted from the generated key rows even though this policy retains them until a major release. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
