github-actions[bot] commented on PR #25583: URL: https://github.com/apache/datafusion/pull/25583#issuecomment-5769528796
<!-- semver-check-comment --> Thank you for opening this pull request! Reviewer note: [cargo-semver-checks](https://github.com/obi1kenobi/cargo-semver-checks) reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch). <details> <summary>Details</summary> ``` Cloning apache/main Building datafusion v55.1.0 (current) Built [ 45.591s] (current) Parsing datafusion v55.1.0 (current) Parsed [ 0.027s] (current) Building datafusion v55.1.0 (baseline) Built [ 44.902s] (baseline) Parsing datafusion v55.1.0 (baseline) Parsed [ 0.029s] (baseline) Checking datafusion v55.1.0 -> v55.1.0 (no change; assume patch) Checked [ 0.812s] 223 checks: 223 pass, 31 skip Summary no semver update required Finished [ 93.731s] datafusion Building datafusion-datasource v55.1.0 (current) Built [ 33.461s] (current) Parsing datafusion-datasource v55.1.0 (current) Parsed [ 0.025s] (current) Building datafusion-datasource v55.1.0 (baseline) Built [ 32.874s] (baseline) Parsing datafusion-datasource v55.1.0 (baseline) Parsed [ 0.025s] (baseline) Checking datafusion-datasource v55.1.0 -> v55.1.0 (no change; assume patch) Checked [ 0.326s] 223 checks: 223 pass, 31 skip Summary no semver update required Finished [ 68.137s] datafusion-datasource Building datafusion-datasource-parquet v55.1.0 (current) Built [ 39.094s] (current) Parsing datafusion-datasource-parquet v55.1.0 (current) Parsed [ 0.026s] (current) Building datafusion-datasource-parquet v55.1.0 (baseline) Built [ 39.938s] (baseline) Parsing datafusion-datasource-parquet v55.1.0 (baseline) Parsed [ 0.027s] (baseline) Checking datafusion-datasource-parquet v55.1.0 -> v55.1.0 (no change; assume patch) Checked [ 0.201s] 223 checks: 223 pass, 31 skip Summary no semver update required Finished [ 80.836s] datafusion-datasource-parquet Building datafusion-ffi v55.1.0 (current) Built [ 41.974s] (current) Parsing datafusion-ffi v55.1.0 (current) Parsed [ 0.049s] (current) Building datafusion-ffi v55.1.0 (baseline) Built [ 41.806s] (baseline) Parsing datafusion-ffi v55.1.0 (baseline) Parsed [ 0.049s] (baseline) Checking datafusion-ffi v55.1.0 -> v55.1.0 (no change; assume patch) Checked [ 0.314s] 223 checks: 221 pass, 1 fail, 1 warn, 31 skip --- failure constructible_struct_adds_private_field: struct no longer constructible due to new private field --- Description: A struct has a new non-public field that causes downstream code to be unable to construct it with a struct expression, including functional-update syntax. ref: https://doc.rust-lang.org/reference/expressions/struct-expr.html impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.50.0/src/lints/constructible_struct_adds_private_field.ron Failed in: field FFI_ExecutionPlan.metrics_for_partition in /home/runner/work/datafusion/datafusion/datafusion/ffi/src/execution_plan.rs:89 --- warning repr_c_plain_struct_fields_reordered: struct fields reordered in repr(C) struct --- Description: A public repr(C) struct had its fields reordered. This can change the struct's memory layout, possibly breaking FFI use cases that depend on field position and order. ref: https://doc.rust-lang.org/reference/type-layout.html#reprc-structs impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.50.0/src/lints/repr_c_plain_struct_fields_reordered.ron Failed in: FFI_ExecutionPlan.partition_statistics moved from position 10 to 11, in /home/runner/work/datafusion/datafusion/datafusion/ffi/src/execution_plan.rs:96 FFI_ExecutionPlan.clone moved from position 11 to 12, in /home/runner/work/datafusion/datafusion/datafusion/ffi/src/execution_plan.rs:103 FFI_ExecutionPlan.release moved from position 12 to 13, in /home/runner/work/datafusion/datafusion/datafusion/ffi/src/execution_plan.rs:106 FFI_ExecutionPlan.version moved from position 13 to 14, in /home/runner/work/datafusion/datafusion/datafusion/ffi/src/execution_plan.rs:109 FFI_ExecutionPlan.private_data moved from position 14 to 15, in /home/runner/work/datafusion/datafusion/datafusion/ffi/src/execution_plan.rs:113 FFI_ExecutionPlan.library_marker_id moved from position 15 to 16, in /home/runner/work/datafusion/datafusion/datafusion/ffi/src/execution_plan.rs:118 Summary semver requires new major version: 1 major and 0 minor checks failed Warning produced 1 major and 0 minor level warnings Finished [ 85.689s] datafusion-ffi Building datafusion-physical-expr-common v55.1.0 (current) Built [ 19.322s] (current) Parsing datafusion-physical-expr-common v55.1.0 (current) Parsed [ 0.017s] (current) Building datafusion-physical-expr-common v55.1.0 (baseline) Built [ 18.822s] (baseline) Parsing datafusion-physical-expr-common v55.1.0 (baseline) Parsed [ 0.017s] (baseline) Checking datafusion-physical-expr-common v55.1.0 -> v55.1.0 (no change; assume patch) Checked [ 0.290s] 223 checks: 223 pass, 31 skip Summary no semver update required Finished [ 39.426s] datafusion-physical-expr-common Building datafusion-physical-plan v55.1.0 (current) Built [ 30.189s] (current) Parsing datafusion-physical-plan v55.1.0 (current) Parsed [ 0.132s] (current) Building datafusion-physical-plan v55.1.0 (baseline) Built [ 30.724s] (baseline) Parsing datafusion-physical-plan v55.1.0 (baseline) Parsed [ 0.132s] (baseline) Checking datafusion-physical-plan v55.1.0 -> v55.1.0 (no change; assume patch) Checked [ 0.906s] 223 checks: 223 pass, 31 skip Summary no semver update required Finished [ 63.684s] datafusion-physical-plan ``` </details> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
