andygrove commented on PR #5394: URL: https://github.com/apache/datafusion-comet/pull/5394#issuecomment-5769943390
@sunchao on the removed-root-sort residual from your last review: this is handled in 0896e36ed. Rather than chasing the mark through the rewrite, the query-stage-prep rule now recognizes a re-plan that AQE collapsed to nothing directly: its logical link has `maxRows == 0`. A genuinely empty query is still reported, because it is planned once and reaches the columnar rule instead. The empty-plan test matrix now includes your two-partition range merge join with `SORT BY a.id % 7`, under both `collect()` and `queryExecution.toRdd.count()`, with AQE on and off. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
