2010YOUY01 commented on PR #25495: URL: https://github.com/apache/datafusion/pull/25495#issuecomment-5770618899
Thank you for the review @adriangb and @alamb > Thanks @2010YOUY01 and @adriangb -- this makes sense to me > > I would personally suggest we try and use a feature for this method rather than not documenting certain methods, but I think this is already an improvement in my mind I agree using features for test utils is better, and help us exclude one special case ``` parent-crate (dev-dependencies includes `test_util` feature) child-crate: with `test_util` feature for public testing APIs ``` However this might not work well for internal optimizer apis, if a user depends on both parent and child crate, the hidden feature can get implicitly enabled. To clean up the remaining internal public APIs, I plan to - Hide test utilities with a new feature - Use the existing approach for others -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
