V0ldek opened a new issue, #25603:
URL: https://github.com/apache/datafusion/issues/25603

   ### Is your feature request related to a problem or challenge?
   
   I was trying to use `datafusion_substrait`. All of the conversion functions 
in `datafusion_substrait::logical_plan` require a `&SessionState`, which you 
can technically obtain from a `Session` impl, but the docs say:
   
   > Migration from `SessionState`
   
   > Using trait methods is preferred, as the implementation may change in 
future versions. However, you can downcast a `Session` to a `SessionState` as 
shown in the example below. If you find yourself needing to do this, please 
open an issue on the DataFusion repository so we can extend the trait to 
provide the required information.
   
   Well, here I am, the `datafusion_substrait` should take a ref to `impl 
Session`, not to `SessionState`.
   
   ### Describe the solution you'd like
   
   From a brief look, the `Session` trait should provide a 
`SerializerRegistry`, which is available in `SessionState` but not exposed in 
the trait.
   
   ### Describe alternatives you've considered
   
   _No response_
   
   ### Additional context
   
   _No response_


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to