andygrove commented on PR #6095: URL: https://github.com/apache/datafusion-comet/pull/6095#issuecomment-5777815186
Thanks for running these, and for spotting the bench breakage — that one had been sitting on `main` for a while and `cargo check --benches` was never going to find it. I had put the fix up as #6104, but on reflection it makes no sense as a separate PR when this is the branch that needs benchmarking, so I have folded it in here and closed that one. All twelve end-to-end benches now complete; before that commit the first one panics. The finding I had not expected is that most of the speedup is the run representation rather than the placement key. If that holds up it is worth having independently of which of the two placement keys wins, so #5449 could take it too. On the partitioning-only microbench needing local visibility changes: I have left it out of this branch rather than widen the exports, but I would rather it existed than not, and it would have to grow past the flush to cover `RunIterator`, which is the part your numbers cannot see. Say the word and I will add it here rather than in a follow-up. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
