dwsmith1983 commented on PR #6041: URL: https://github.com/apache/datafusion-comet/pull/6041#issuecomment-5781109856
@andygrove the two red jobs came from the codegen factory mode read in the aggregate gate: Spark 3.4 has no `codegenFactoryMode` accessor, and on 4.1 it returns the enum rather than a string. 9673bf9b1 reads the conf entry's string form instead, which compiles on every profile. Locally the module test-compiles on 3.4, 3.5, 4.0 and 4.1, and the aggregate and window suites still pass on 3.5, including the case that forces `NO_CODEGEN`. Main is merged in as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
