sam-1112 commented on PR #6111: URL: https://github.com/apache/datafusion-comet/pull/6111#issuecomment-5789319395
Thanks @andygrove . I pushed an update for the review comments. * Added a note for why this suite uses `local[5,2]`. * Changed the blocker setup to cover a few candidate output paths instead of relying on only `max + 1`. * Kept the first-attempt failure around so the final assertion shows the actual reason when the retry setup doesn't behave as expected. * Moved the parquet file scan into `IcebergTestFiles` and filtered it to regular files only. I also reran the suite and repeated the new retry test to check for flakiness. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
