adriangb commented on PR #23565: URL: https://github.com/apache/datafusion/pull/23565#issuecomment-5789768398
## Benchmark bot results after rebase (head `2918b059cb`, base `207d7f3c27`) A/B = main vs this PR, A/A = main vs main. Ratios are branch / base (>1.00 = slower with this PR). ### spill_views with `SPILL_VIEWS_LIMIT_DISTINCT=128M` (q05 now finishes on both sides) | Query | A/B run 1 | A/B run 2 | A/A run 1 | A/A run 2 | | --- | --- | --- | --- | --- | | q01 sort, 1 distinct value | 105.5 → 88.4 ms (**0.84x**) | 105.3 → 90.4 ms (**0.86x**) | 1.09x | 1.01x | | q02 sort, 1000 distinct values | 0.98x | 0.99x | 1.00x | 1.01x | | q03 sort, BinaryView, 1000 distinct | 1.00x | 0.97x | 1.01x | 1.00x | | q04 sort, all distinct | 126.6 → 180.7 ms (**1.43x**) | 126.3 → 174.3 ms (**1.38x**) | 1.03x | 0.99x | | q05 GROUP BY, all distinct | 1.05x | 0.99x | 0.96x | 1.00x | ### spill_views at the default limits | | A/B runs | Result | | --- | --- | --- | | This round | 1 | q05 fails on the branch side at 96M | | All rounds | 5 | 5 failed, always on the branch side; A/A 0 of 3 failed | ### sort_tpch, 512M limit, 4 partitions | Query | A/B | A/A | | --- | --- | --- | | Q8 (`l_comment`) | 497 → 514 ms (1.03x) | 495 → 522 ms (1.05x) | | Q9 (`l_comment`) | 539 → 568 ms (1.05x) | 537 → 552 ms (1.03x) | | Q11 (`l_comment`) | 381 → 418 ms (**1.10x**) | 381 → 386 ms (1.01x) | | Total | 4316 → 4423 ms (1.02x) | 4357 → 4447 ms (1.02x) | The A/A run was noisier this round, so only Q11 stands out. It matches the earlier runs (1.11x and 1.08x). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
