alamb commented on code in PR #12126:
URL: https://github.com/apache/datafusion/pull/12126#discussion_r1729937785
##########
datafusion/optimizer/src/utils.rs:
##########
@@ -28,6 +28,10 @@ use datafusion_expr::{logical_plan::LogicalPlan, Expr,
Operator};
use log::{debug, trace};
+/// Re-export of `NamesPreserver` for backwards compatibility,
+/// as it was initially placed here and then moved elsewhere.
Review Comment:
👍
##########
datafusion/expr/src/expr_rewriter/mod.rs:
##########
@@ -279,6 +279,57 @@ where
expr.alias_if_changed(original_name)
}
+/// Handles ensuring the name of rewritten expressions is not changed.
Review Comment:
FYI @findepi here is an example of using Expr::Alias as described in
https://github.com/apache/datafusion/issues/1468#issuecomment-2308237517
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
