dwsmith1983 commented on PR #5654: URL: https://github.com/apache/datafusion-comet/pull/5654#issuecomment-5793256106
> The initial reason I was slightly concerned is 2k LOC to patch an extreme scenario Cut down in 24030e526, as offered above. The footer-time validator is gone with its tests, so the reader factory and the scan setup are back to main and the Rust test bulk with them. What stays is what #5786 does not cover: the resolver raising Spark's duplicate-id error for an ambiguous requested id at any nesting level, exact-name lookups that bind the way Spark's do, the id shield against a stray same-name column, one list definition across the mapping paths, and the field mapping resolved once per file instead of per batch. The JNI cause-chain walk went too: restoring main's error conversion left every kept test green, because the adapter raises its errors at the top level, so that piece only served the footer check. The description is rewritten to match, with the remaining gap stated in full: a metadata-free file whose schema equals the requested one is still read positionally because the opener skips the adapter, #6004 covers the case where the requested schema itself repeat s an id, and nested duplicate names in such a file are tracked in #6136. Against main the diff is now 6 files changed, 2102 insertions(+), 356 deletions(-), down from 9 files with 2898 insertions and 384 deletions; the reader factory, the scan setup and the JNI error conversion are back to main byte for byte. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
