2010YOUY01 commented on code in PR #25586: URL: https://github.com/apache/datafusion/pull/25586#discussion_r4082059402
########## docs/source/contributor-guide/testing.md: ########## @@ -320,6 +320,26 @@ the README: [`dev/update_function_docs.sh`]: https://github.com/apache/datafusion/blob/main/dev/update_function_docs.sh [`ci/scripts/check_generated_docs.sh`]: https://github.com/apache/datafusion/blob/main/ci/scripts/check_generated_docs.sh +## Documentation HTML Build Review Comment: Small optional advice, we can do it after finishing all scripts. This `testing.md` is an entry-point documentation for testing, so I think we don't have to explain all non-functional tests in detail. The detailed documentation could go to individual scripts. Maybe it's enough to list all of them, and briefly introduce them in 1-2 sentences here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
