andygrove commented on PR #5876: URL: https://github.com/apache/datafusion-comet/pull/5876#issuecomment-5796917182
Now that `Strict Scala warnings` gates the PR tier and the queue, could we add a step to the "Submitting a Pull Request" checklist in `docs/source/contributor-guide/development.md` next to the Clippy step? The default build profile is Spark 4.1 on Scala 2.13, which doesn't raise most of these warnings. So someone who only builds the default profile will get a red job with no hint of how to reproduce it. Something like `./mvnw test-compile -Pspark-3.5 -Pstrict-warnings -DskipTests` with a sentence explaining why it's the 3.5 profile would cover it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
