comphead commented on code in PR #6125:
URL: https://github.com/apache/datafusion-comet/pull/6125#discussion_r4084171056
##########
docs/source/user-guide/latest/metrics.md:
##########
@@ -163,6 +163,7 @@ execution metrics. Counters accumulate per scan operator;
they do not instrument
| `scan_io_object_store_response_bytes_read` | Response bytes actually
consumed at that API, including bytes fetched between coalesced ranges. Not
HTTP wire bytes.
|
| `scan_io_metadata_cache_hits` | Successful, cache-eligible
metadata opens requiring no storage reads.
|
| `scan_io_metadata_cache_misses` | Successful, cache-eligible
metadata opens requiring storage reads. Failed opens and encrypted opens, which
bypass this shared cache, increment neither cache counter.
|
+| `scan_io_unreserved_bytes` | Bytes the scan held without a
memory reservation because the pool refused it: fetched data pages, plus the
per-reader decode-buffer estimate. The scan cannot spill, so it keeps reading
instead of failing. |
Review Comment:
maybe we can elaborate it a little bit, so big number in this metric is a
bad sign. Does that mean a mem leak for scan operations?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
