LucaCappelletti94 commented on PR #2565: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/2565#issuecomment-5801644464
I would agree to not block if the threshold was 100, but 80% should be most likely covered by anyone adding tests to a PR. If you prefer, I could lower it down to like 70%. I would prefer for contributors to act on low coverage autonomously as they see the failure, before reviewers need to point it out. A non failure may not be strong enough. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
