andygrove commented on PR #25651: URL: https://github.com/apache/datafusion/pull/25651#issuecomment-5804216635
@comphead I addressed the smaller points in f79c1f984: - `allocated_bytes` is no longer public, and `CountingAllocator` no longer takes a type parameter; it always uses `System`. - I merged the negative-drift test into the threshold test, and the `tracker()` test helper now takes a threshold. - The Substrait round-trip engine now calls `rewrap_replaced_pool` too. With the call, `information_schema.slt` and `set_variable.slt` log 40 and 5 drift lines in round-trip mode. Without it, they log 37 and 2. - The `--memory-drift` help text now names `RUST_LOG=datafusion_execution::memory_pool=info` and says that only rises of `--memory-drift-log-threshold` bytes are logged. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
