2010YOUY01 commented on PR #25588:
URL: https://github.com/apache/datafusion/pull/25588#issuecomment-5806094162
I'm not familiar with these scripts, so I can't review this with a quick
look. I'm leaving my current questions and will try to follow up later, once I
can find some contiguous time to batch some lint work.
Questions:
> * `ci/scripts/check_semver.sh` runs the same comparison as the "Detect
> breaking changes" workflow, through `ci/scripts/changed_crates.sh`.
1. There are two separate scripts for Github and local runs, for the same
purpose? Anyway we can unify them.
2. In the local check, failing the check due to API change seem not
reasonable, we just have to mark them and try to inspect them in the review
3. I tried to add an API change on top of this PR, but local `rust_lint.sh`
passed
https://github.com/apache/datafusion/commit/d320d4ac4745c91ece66a8a67764b302ab1e118c
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
