irenjj commented on code in PR #12049:
URL: https://github.com/apache/datafusion/pull/12049#discussion_r1730310539
##########
datafusion/physical-expr/src/expressions/binary.rs:
##########
@@ -296,7 +296,9 @@ impl PhysicalExpr for BinaryExpr {
Operator::Minus => return apply(&lhs, &rhs, sub_wrapping),
Operator::Multiply if self.fail_on_overflow => return apply(&lhs,
&rhs, mul),
Operator::Multiply => return apply(&lhs, &rhs, mul_wrapping),
- Operator::Divide => return apply(&lhs, &rhs, div),
+ Operator::Divide => {
+ return apply(&lhs, &rhs, div);
Review Comment:
@andygrove , should we add a new function in arrow(like `div_zero`) to
return None. It seems a bit difficult to rewrite `div` in `binary.rs`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
