LucaCappelletti94 opened a new pull request, #2566: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/2566
`Visitor` has hooks for only a handful of node types, so a visitor cannot reach a `Join`, `SelectItem` or `ColumnDef` without walking the tree by hand. Following the approach agreed in #934, the `Visit` derive now calls `pre_visit_node` and `post_visit_node` around every node. Both do nothing by default. The hook receives a `NodeRef`. It downcasts to the concrete type, reports the type and variant name, and exposes `&dyn Spanned` and `&dyn Display` when the type implements them. New AST types need no registration. The four generic AST types gain a `'static` bound, which every AST type already meets. Closes #934. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
