alamb commented on issue #11364: URL: https://github.com/apache/datafusion/issues/11364#issuecomment-2308790111
> Once the final physical plan is generated in create_physical_plan() after all the optimizer passes, we can then visit all the nodes and call "with_node_id" on them. Does this sound like a reasonable approach? I do think this sounds reasonable Some questions and thoughts: 1. What would be the default value of id (if `with_node_id` wasn't called)? 2. You might want to consider an API like `pub fn with_node_id(self: Arc<...>, node_id: usize` if you can as the ExcutionPlan nodes are almost always `Arc`d) 3. I would recommend not showing this id in the explain plan if they change / are not deterministic -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
