timsaucer commented on code in PR #808:
URL: https://github.com/apache/datafusion-python/pull/808#discussion_r1730340120
##########
python/datafusion/functions.py:
##########
@@ -1479,12 +1502,17 @@ def approx_percentile_cont(
"""Returns the value that is approximately at a given percentile of
``expr``."""
if num_centroids is None:
return Expr(
- f.approx_percentile_cont(expression.expr, percentile.expr,
distinct=distinct, num_centroids=None)
+ f.approx_percentile_cont(
+ expression.expr, percentile.expr, distinct=distinct,
num_centroids=None
+ )
)
return Expr(
f.approx_percentile_cont(
- expression.expr, percentile.expr, distinct=distinct,
num_centroids=num_centroids.expr
+ expression.expr,
Review Comment:
Ok, it looks like we are not using `ci/scripts/python_lint.sh` which I'm
guessing we were at one point. Instead the ruff checks happen in
`.github/workflows/build.yml`. This only runs `ruff check` and not `ruff
format` but pre-commit *does* run `ruff format`. That's why these changes are
happening in my commits but not failing CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
