LucaCappelletti94 commented on PR #2482: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/2482#issuecomment-5812668279
@alamb I pushed the follow-ups from my review to your branch. `sqlparser_bench` is now a workspace member, so one lockfile covers everything except `fuzz/`, which keeps its own workspace and ignores its lockfile as before. Every cargo command in CI now runs with `--locked`, so a dependency change that is not committed to `Cargo.lock` fails the build, and the lockfile diff is where reviewers see it. `.tool-versions` is bumped to 1.88.0 and kept the lockfile at version 4. Making `sqlparser_derive` a workspace member also brings it under clippy, which flagged one `sort_by` that I changed to `sort_by_key`. One consequence worth knowing is that the daily `cargo audit` now checks the committed lockfile, so a new advisory will fail it until someone runs `cargo update`. LMK whether all looks good to you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
