andygrove commented on code in PR #6191:
URL: https://github.com/apache/datafusion-comet/pull/6191#discussion_r4095246436
##########
spark/src/main/scala/org/apache/comet/CometConf.scala:
##########
@@ -727,9 +727,9 @@ object CometConf extends ShimCometConf {
"shuffle data to disk. Larger values may improve write performance by
reducing " +
"the number of system calls, but will use more memory. " +
"The default is 1MB which provides a good balance between performance
and memory usage.")
- .bytesConf(ByteUnit.MiB)
+ .bytesConf(ByteUnit.BYTE)
.checkValue(v => v > 0, "Write buffer size must be positive")
- .createWithDefault(1)
+ .createWithDefault(1024 * 1024)
Review Comment:
You're right, it's four, and I've updated the description to say 4 MiB. I'd
rather keep the accounting out of this PR, so I filed #6196 for it. One catch
with growing the `ShuffleRepartitioner` reservation is that `spill()` releases
all of it with `free()`, so the buffers would stop being counted at the first
spill. The issue suggests a second reservation on the same consumer, from
`new_empty()`, instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
