findepi commented on issue #1468: URL: https://github.com/apache/datafusion/issues/1468#issuecomment-2308891696
> I think Sort would be an easier thing to remove / fix -- `Expr::Sort` as an expression is also bad as it means the signatures of `fn order_by(...)` are in terms of `Expr`, meaning the compiler can't ensure you are actually passing `Expr::Sort` when needed Indeed. There are a few places where sort expression needs to be special cased. > There are likely other ways to handle this than Expr::Alias (a separate list on Projection, for example) but I do think alias is used widely I see the point. I would be tempted to go into direction where names are explicit and expressions are just expressions. Ie to model projects as `map<String /* name to assign */, Expr /* value to calculate */>` one thing is how easy it is to get there (i get that likely pretty hard per "alias is used widely") and the other is whether we would want to get there at all (is this the right direction) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
