villebro commented on code in PR #1916:
URL:
https://github.com/apache/datafusion-ballista/pull/1916#discussion_r4099770959
##########
ballista/core/proto/ballista.proto:
##########
@@ -829,6 +829,12 @@ message FailedTask {
}
}
+message TaskColumnStats {
+ uint32 column = 1;
+ uint64 null_count = 2;
+ bytes hll_sketch = 3;
Review Comment:
I was thinking more along the lines of making it
```
repeated ColumnSketch sketches = 3;
```
and then something like
```
message ColumnSketch {
SketchType type = 1;
bytes data = 2;
}
enum SketchType {
SKETCH_TYPE_UNSPECIFIED = 0;
SKETCH_TYPE_HLL = 1;
...
}
```
Basically, keep the implementation HLL-only for now, but make the wire
format generic enough to support multiple sketch types. We could then add
`SKETCH_TYPE_KLL = 2`, etc. later without adding dedicated fields to
`TaskColumnStats` for every sketch type.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
