yjshen commented on code in PR #12157:
URL: https://github.com/apache/datafusion/pull/12157#discussion_r1730400765
##########
datafusion/core/tests/memory_limit/mod.rs:
##########
@@ -141,7 +141,7 @@ async fn join_by_expression() {
TestCase::new()
.with_query("select t1.* from t t1 JOIN t t2 ON t1.service !=
t2.service")
.with_expected_errors(vec![
- "Resources exhausted: Additional allocation failed with top memory
consumers (across reservations) as: NestedLoopJoinLoad[0]",
+ "Resources exhausted: Additional allocation failed with top memory
consumers (across reservations) as: NestedLoopJoinLoad[0]",
Review Comment:
Could you please revert all unintentional space-adding changes in the PR as
well? Thanks!
##########
datafusion/core/tests/parquet/file_statistics.rs:
##########
@@ -198,7 +198,8 @@ fn get_cache_runtime_state() -> (
.with_list_files_cache(Some(list_file_cache.clone()));
let rt = Arc::new(
-
RuntimeEnv::new(RuntimeConfig::new().with_cache_manager(cache_config)).unwrap(),
+
RuntimeEnv::new(RuntimeEnvBuilder::new().with_cache_manager(cache_config))
Review Comment:
I thought the issue intended to avoid calling `RuntimeEnv::new`, instead
have it constructed via the builder pattern:
```rs
let runtime: RuntimeEnv = RuntimeEnvBuilder::new()
.with_xxx()
.with_yyy()
.build()
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
