andygrove commented on PR #6031: URL: https://github.com/apache/datafusion-comet/pull/6031#issuecomment-5833964501
> Thanks @snmvaughan. Deriving the location bridges from the bucket's bridge closes the interaction with #6023. I checked `13e634463` locally, merged with main. The `location_scoped`, `objectstore` and `parquet_support` tests pass, and clippy and fmt are clean. > > The refresh concern on `location_scoped.rs:130` still reproduces, and I filed #6221 for it. I don't think it needs to hold up this PR. It is not a regression, because only providers that implement the new interface take the new path, and nobody does yet. It fails loudly, with no wrong results and no fallback to a broader credential, and a one-off provider error doesn't stick. What persists is stale routing after a vendor's locations change while the executors are up, until they restart. > > I would like the fix to land in the same release that ships the interface, though. Otherwise vendors building against it would have to learn the workaround, and the guide's "picked up" claim wouldn't hold for a provider without a bucket-wide credential. Would you be able to pick up #6221? I'm going to create a PR now to fix the issue -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
