SubhamSinghal commented on PR #25468: URL: https://github.com/apache/datafusion/pull/25468#issuecomment-5834916632
@jayzhan211 thanks. 1. I hadn't applied your fix as written. Mine did a `HashMap` lookup per row instead of per entry. I've switched to your version in [b1915bc (https://github.com/apache/datafusion/pull/25468/commits/b1915bc52e401d5af18dcfb3c87117dab1c7f306). I also extended the Dictionary test to assert the full emit order, with a chunk boundary inside a single entry, which covers the `array_pos = None` reset. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
