andygrove commented on PR #6218: URL: https://github.com/apache/datafusion-comet/pull/6218#issuecomment-5848233439
Note to self for the backports once this merges. branch-1.1: cherry-pick the squash commit onto `apache/branch-1.1`. It should apply cleanly, since the CI files there are identical to this PR's base. Title it `ci: [branch-1.1] run every tier on release-branch pull requests, and the full suite before an RC (#6218)`. Open it without labels, then add `run-spark-3.4-tests`, so the label run adds only Spark 3.4. Its own run uses the new routing, so it should run every suite except the benchmark check. It will also be the first time the Spark SQL, Iceberg, PyArrow and macOS jobs run against the 1.1.0 version bump (#6236), so if one of those goes red, check for a `-SNAPSHOT` jar glob before blaming the backport. Don't dispatch `ci.yml` on branch-1.1 until that merges. Its `docs` job has no guard yet, so a dispatch would publish branch-1.1's docs over the site. Once it's in, `git show apache/branch-1.1:.github/workflows/ci.yml | sed -n '/^ docs:/,/uses:/p'` should show `github.ref == 'refs/heads/main'`, and the pre-RC dispatch of `ci.yml` and `miri.yml` is safe. branch-1.0: nothing to backport. #6229 already added the `docs` guard, and the dispatch before each 1.0.x RC covers the suites its pull requests skip. Spark SQL 3.4 and 4.0 and Iceberg 1.8, 1.9 and 1.10 have never run against anything merged there, so dispatch it well before a 1.0.1 RC, once #6228 lands. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
