andygrove opened a new pull request, #2495:
URL: https://github.com/apache/datafusion-ballista/pull/2495

   # Which issue does this PR close?
   
   No separate issue. Split out of #2416 at review request, to keep that PR to 
the Flight SQL frontend itself.
   
   # Rationale for this change
   
   The Flight SQL frontend in #2416 lives in its own crate below 
`ballista-scheduler` and needs to reuse `BallistaFlightProxyService` to stream 
partitions back from executors. The proxy is currently private to the scheduler.
   
   # What changes are included in this PR?
   
   - Move `flight_proxy_service.rs` from `ballista-scheduler` to 
`ballista-core` as `ballista_core::flight_proxy_service`. The scheduler now 
imports it from there.
   - `do_get` reports a ticket that cannot be decoded as `InvalidArgument` 
instead of `Internal`, since it is a client error. Covered by a new test.
   - Add `layout()` to the protobuf `PartitionLocation`, sharing the rule with 
the existing `PartitionLocation::layout`, and use it in 
`DistributedQueryExec`'s `fetch_partition` instead of an inlined copy.
   
   # Are there any user-facing changes?
   
   `BallistaFlightProxyService` becomes public in `ballista-core`. A malformed 
ticket sent to the scheduler's embedded Flight proxy now fails with 
`InvalidArgument` instead of `Internal`. Nothing else changes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to