findepi commented on code in PR #12177:
URL: https://github.com/apache/datafusion/pull/12177#discussion_r1731786288
##########
datafusion/core/src/datasource/listing/table.rs:
##########
@@ -1159,11 +1159,6 @@ mod tests {
// (file_sort_order, expected_result)
let cases = vec![
(vec![], Ok(vec![])),
- // not a sort expr
- (
- vec![vec![col("string_col").sort(true, false)]],
- Err("Expected Expr::Sort in output_ordering, but got
string_col"),
- ),
Review Comment:
test case removed because the API now makes it impossible to provide wrong
expression type
##########
datafusion/optimizer/src/eliminate_limit.rs:
##########
@@ -187,7 +187,7 @@ mod tests {
// After remove global-state, we don't record the parent <skip, fetch>
// So, bottom don't know parent info, so can't eliminate.
let expected = "Limit: skip=2, fetch=1\
- \n Sort: test.a, fetch=3\
+ \n Sort: test.a ASC NULLS LAST, fetch=3\
Review Comment:
don't remember if this is just rendering fix for TopK plan?
##########
datafusion/core/tests/expr_api/mod.rs:
##########
@@ -167,21 +167,6 @@ fn test_list_range() {
);
}
-#[tokio::test]
-async fn test_aggregate_error() {
- let err = first_value_udaf()
- .call(vec![col("props")])
- // not a sort column
- .order_by(vec![col("id").sort(true, false)])
- .build()
- .unwrap_err()
- .to_string();
- assert_contains!(
- err,
- "Error during planning: ORDER BY expressions must be Expr::Sort"
- );
-}
Review Comment:
test case removed because the API now makes it impossible to provide wrong
expression type
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
