timsaucer commented on code in PR #1763:
URL:
https://github.com/apache/datafusion-python/pull/1763#discussion_r4124299759
##########
python/datafusion/dataframe.py:
##########
@@ -108,6 +108,32 @@ class ExplainFormat(Enum):
"""Graphviz DOT format for graph rendering."""
+class ExplainAnalyzeLevel(Enum):
Review Comment:
Not taking this one. The package root has grown to hold nearly every public
class, which makes it hard to predict where anything lives: `ExplainFormat` is
at the root, and so is `WindowFrame`, but `Window` is not. 55.0.0 already
started the other direction: the new extension protocols live only in
`datafusion.extensions`, and `SessionExtensionComponents` stays at the root
"because a bundle constructs one rather than merely naming it".
`ExplainAnalyzeLevel` and `ExplainMetricCategory` are only ever named as
arguments to `DataFrame.explain`, so they stay in `datafusion.dataframe`. I've
opened #1771 to apply the same rule to the rest of the root, with a deprecation
period, rather than extend the current pattern here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
