andygrove commented on PR #5416: URL: https://github.com/apache/datafusion-comet/pull/5416#issuecomment-5876128436
This is a light fully automated review since there are so many PRs open. The regex and multi-byte cases you added to `split_rust.sql` don't look like they actually run. `SqlFileTestParser.parse` (`spark/src/test/scala/org/apache/comet/SqlFileTestParser.scala`) only turns a line into a test record when it is exactly `statement` or starts with `query`. Anything else, including a bare `SELECT` line, falls into the `case _ => lineIdx += 1` branch and is skipped exactly like a blank line or a comment. `spark/src/test/resources/sql-tests/expressions/string/split_rust.sql:42` and `:45` both go straight from a `--` comment to the `SELECT`, with no `query` line in between, so neither one ever becomes a `SqlQuery` record for `CometSqlFileTestSuite` to run. That means the `\d+` regex case and the multi-byte `→` delimiter case sit in the file but never execute as part of the suite. Would you add a `query` line above each of those two `SELECT`s? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
