andygrove commented on PR #6135: URL: https://github.com/apache/datafusion-comet/pull/6135#issuecomment-5876181206
This is a light fully automated review since there are so many PRs open. The `reserved 5` / `reserved "allow_incompat"` lines in `expr.proto` match how retired fields are handled elsewhere. But the Rust test targets no longer compile at the current head. `SparkParquetOptions::new` (`native/core/src/parquet/parquet_support.rs:126`) and `SparkCastOptions::new` (`native/spark-expr/src/conversion_funcs/cast.rs:147`) now take two arguments, and I count 14 call sites in `#[cfg(test)]` modules across 6 files that still pass three. Some examples are `native/core/src/parquet/schema_adapter.rs:3106`, `native/core/src/parquet/parquet_support.rs:2130`, `native/core/src/parquet/cast_column.rs:396`, `native/core/src/execution/operators/iceberg_scan.rs:633`, and `native/spark-expr/src/conversion_funcs/cast.rs:1249`. That is the same `E0061` shape that was flagged once on `schema_adapter.rs` earlier in review. Most of them are the `issue_5783_*` duplicate field id tests from #5654, which came in with the latest merge of `main`. So `cargo test` and `cargo clippy --all- targets` fail even though the library itself builds. Could you update these calls to the two-argument form? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
