wudidapaopao commented on PR #25849: URL: https://github.com/apache/datafusion/pull/25849#issuecomment-5898815704
> This has buried within it a set of interface enhancements to `Accumulator` and `GroupsAccumulator` that add support for functions with no inputs but still have information about the number of rows. I think those changes are important enough to be assessed outside of the context here. Could you make a separate PR for the interface changes so they can be considered aside from the use case please? That makes sense. I've split the interface changes into <PR link>. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
