IgnatiusPang commented on PR #25746: URL: https://github.com/apache/datafusion/pull/25746#issuecomment-5907224128
Thanks for your patience @alamb. I pushed 5a32daf, which fixes the fmt failure and updates the two `order.slt` plans that caused the test failures. Those tests use `c11`/`c12`, which are in `(0, 1)`, so the removed sort was actually unsafe. I also replaced the reproducer in the description: the original one didn't hit the bug, because a plain `VALUES` input has no ordering for the optimizer to rely on. Could you approve the workflow run when you have a moment? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
