rich7420 commented on PR #6069: URL: https://github.com/apache/datafusion-comet/pull/6069#issuecomment-5912754603
Updated this PR to `3e8625af8` with a native sliding accumulator instead of falling back to Spark. It checks ordered prefix extrema after retraction, so it detects intermediate overflow and recovers when the offending values leave the frame. ANSI/TRY sums cannot be reversed because that changes overflow behavior. [Fork CI](https://github.com/rich7420/datafusion-comet/actions/runs/36705945244) passed, including all nine Spark 4.1 SQL shards. Local Spark 4.1 Window/SQL tests (70), focused Spark 3.5 tests (4) and Rust SUM tests (10) also passed. The 12-case local benchmark was faster than Spark-window fallback in every case, at 1.29–31.94x. The PR description records the workload and limits. Keeping this draft for the new upstream CI and a fresh review of the native implementation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
