rgbuilds commented on PR #25854:
URL: https://github.com/apache/datafusion/pull/25854#issuecomment-5913659646

   Thanks for this optimization. In `row_group_filter.rs`, I noticed this 
branch records a Bloom match even though Bloom reads and evaluation are skipped:
   
   ```rust
   if self.access_plan.is_fully_matched(idx) {
       metrics.row_groups_pruned_bloom_filter.add_matched(1);
       continue;
   }
   ```
   
   This overlaps with #25822 (addressing #18355), which proposes counting only 
actual Bloom evaluation outcomes. I’ll incorporate this new path and extend the 
test to cover its metric accounting when updating that PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to