andygrove commented on code in PR #6324: URL: https://github.com/apache/datafusion-comet/pull/6324#discussion_r4155655848
########## spark/src/test/resources/sql-tests/expressions/array/arrays_zip.sql: ########## @@ -141,6 +141,12 @@ INSERT INTO test_arrays_zip VALUES (array(1), array(10, 20)), (array(2, 3), arra query select arrays_zip(a, b) FROM test_arrays_zip +query +select arrays_zip(a, a) FROM test_arrays_zip Review Comment: I think this query fails today. `arrays_zip(a, a)` produces a struct with two children named `a`, and the Arrow Java importer collapses them into one. Could you run this case and `arrays_zip(b, b)` below against the JVM import path and confirm they pass without a fix in the serde? If they fail, a `query expect_fallback(...)` case paired with a `getSupportLevel` guard would cover it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
