dwsmith1983 commented on code in PR #25658:
URL: https://github.com/apache/datafusion/pull/25658#discussion_r4156283077
##########
datafusion/physical-plan/src/joins/hash_join/stream.rs:
##########
@@ -386,6 +388,9 @@ pub(super) struct HashJoinStream {
probe_indices_buffer: Vec<u32>,
/// Scratch space for build indices during hash lookup
build_indices_buffer: Vec<u64>,
+ /// Key comparator for the current probe batch, built on first use and
+ /// reused by every chunk of that batch
+ probe_key_comparator: Option<JoinKeyComparator>,
Review Comment:
Thanks @jayzhan211, that is cleaner. Done in c6d72245f: the comparator now
lives on `ProcessProbeBatchState`, the stream field and both resets are gone,
and `JoinKeyComparator` gets a manual `Debug` impl.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
