zhangfengcdt commented on PR #6494: URL: https://github.com/apache/datafusion-comet/pull/6494#issuecomment-5933474463
> There are several remaining references to the old key names outside the generated config reference: > > * `.ai/skills/review-comet-iceberg-write-pr/SKILL.md` > * `.github/workflows/spark_sql_writer_tests.yml` > * `benchmarks/pyspark/run_all_benchmarks.sh` > * `spark/src/test/scala/org/apache/spark/sql/benchmark/CometIcebergWriteBenchmark.scala` > * the Iceberg fixtures under `dev/diffs/iceberg/` > > Could we update these to the new canonical names as part of the rename? In particular, leaving scripts and reviewer guidance on the old spelling means they continue exercising and recommending the alias instead of the canonical key. The `dev/diffs/` files should be regenerated using the documented Spark SQL test workflow rather than hand-edited. Thanks for the review @andygrove ! I have made the requested changes as followings: - removed both `withAlternative` aliases, the alias tests, and the deprecation wording. - updated the remaining references: the review skill, the workflow comment, the benchmark script, and `CometIcebergWriteBenchmark`. - regenerated all four Iceberg diffs with the documented workflow. The regenerated diffs differ in the 220 key lines and their `index` lines. Also, I updated the PR description to reflect the new changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
