neilconway commented on code in PR #25935:
URL: https://github.com/apache/datafusion/pull/25935#discussion_r4157387957
##########
datafusion/functions/src/core/getfield.rs:
##########
@@ -351,11 +349,8 @@ impl ScalarUDFImpl for GetFieldFunc {
// the underlying struct, then wrap the result back in the
// same Dictionary type so the promised type matches execution.
DataType::Dictionary(key_type, value_type)
- if matches!(value_type.as_ref(), DataType::Struct(_)) =>
+ if let DataType::Struct(fields) = value_type.as_ref() =>
{
- let DataType::Struct(fields) = value_type.as_ref() else {
- unreachable!()
- };
Review Comment:
Minor code cleanup enabled by the MSRV bump.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
