andygrove opened a new pull request, #6516:
URL: https://github.com/apache/datafusion-comet/pull/6516
## Which issue does this PR close?
Part of #6399. This is the skills half of its Phase 5.
## Rationale for this change
The 1.1.0 regression audit (#6399) found 20 regressions that got past
review. Seven were fixed before rc1, and 13 shipped in rc1 and are tracked in
#6402. Most came from three kinds of change: a path that became native by
default, a removed fallback, and a broad routing change. Their tests never used
the inputs where the new path differed from Spark. Phase 5 of the audit asked
for those lessons to go into the review skills, so that the next review checks
for them.
## What changes are included in this PR?
- `review-comet-pr`:
- a new check, "Behavior against the last release"
- two disguised forms of a `Compatible` divergence: a documented
divergence on a path that's on by default, and a test switched to `ignore`
- Spark behavior changes in patch releases, and the pull request CI
running only the default profile
- a supported off switch for a default-on change that trades performance
- tests that compare against a second implementation instead of Spark
- a list of inputs that broke earlier changes
- the paths CI doesn't cover
- a new "Dependency upgrades" check
- `review-comet-expression-pr`: catch-alls into the codegen dispatcher, the
merge order of partial aggregate states, signed zeros and NaN including inside
nested types, Iceberg's Java implementation as the reference for Iceberg
functions, and ignored tests that need a fallback.
- `review-comet-memory-pr`: a run that spills under a tight pool and reads
the spill back, for DataFusion upgrades and changes to spilling operators.
Each item cites the regression it comes from.
## How are these changes tested?
These are skill documents only. Prettier passes on the changed files.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
