haohuaijin commented on code in PR #25731:
URL: https://github.com/apache/datafusion/pull/25731#discussion_r4164839100
##########
datafusion/datasource-parquet/src/opener/mod.rs:
##########
@@ -4327,9 +4313,108 @@ mod test {
}
#[tokio::test]
- async fn test_reverse_scan_with_row_selection() {
- use parquet::file::properties::WriterProperties;
+ async fn test_dynamic_pruning_preserves_external_row_selection() {
+ let store = Arc::new(InMemory::new()) as Arc<dyn ObjectStore>;
Review Comment:
Sorry, I forgot to include this test in
[#25608](https://github.com/apache/datafusion/pull/25608). It guards against
losing external row selections during [decoder rebuilds after runtime
pruning](https://github.com/apache/datafusion/blob/416002a5b908d990f0497ad4fc9d4438e513c210/datafusion/datasource-parquet/src/push_decoder.rs#L672-L683)
if the selection guard is accidentally removed. Sorry for not making that
clear — happy to remove it if you prefer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
