andygrove commented on PR #6413: URL: https://github.com/apache/datafusion-comet/pull/6413#issuecomment-5951005308
Added both in d66bcee0f: - A map-of-float case in the `shapes` closure in `murmur3.rs` (float as both key and value, checked for murmur3 and xxhash64), and a `hash(map(-d, -f))` / `xxhash64(map(-d, -f))` query in `hash.sql`. Spark rejects hashing a map by default, so the file now sets `spark.sql.legacy.allowHashOnMapType=true`. - `nested_floats_fold_negative_zero_and_nan` in `hll_plus_plus.rs`, which runs a struct-of-float and a list-of-float through the accumulator and expects the two zeros and the NaN bit patterns to count as 2 distinct values. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
