github-actions[bot] commented on PR #25963: URL: https://github.com/apache/datafusion/pull/25963#issuecomment-5950052982
<!-- semver-check-comment --> Thank you for opening this pull request! Reviewer note: [cargo-semver-checks](https://github.com/obi1kenobi/cargo-semver-checks) reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch). <details> <summary>Details</summary> ``` Cloning apache/main Building datafusion-expr v55.1.0 (current) Built [ 24.164s] (current) Parsing datafusion-expr v55.1.0 (current) Parsed [ 0.066s] (current) Building datafusion-expr v55.1.0 (baseline) Built [ 24.030s] (baseline) Parsing datafusion-expr v55.1.0 (baseline) Parsed [ 0.066s] (baseline) Checking datafusion-expr v55.1.0 -> v55.1.0 (no change; assume patch) Checked [ 1.765s] 223 checks: 223 pass, 31 skip Summary no semver update required Finished [ 51.593s] datafusion-expr Building datafusion-physical-expr v55.1.0 (current) Built [ 23.895s] (current) Parsing datafusion-physical-expr v55.1.0 (current) Parsed [ 0.039s] (current) Building datafusion-physical-expr v55.1.0 (baseline) Built [ 22.885s] (baseline) Parsing datafusion-physical-expr v55.1.0 (baseline) Parsed [ 0.039s] (baseline) Checking datafusion-physical-expr v55.1.0 -> v55.1.0 (no change; assume patch) Checked [ 0.460s] 223 checks: 223 pass, 31 skip Summary no semver update required Finished [ 48.424s] datafusion-physical-expr Building datafusion-physical-expr-common v55.1.0 (current) Built [ 18.955s] (current) Parsing datafusion-physical-expr-common v55.1.0 (current) Parsed [ 0.017s] (current) Building datafusion-physical-expr-common v55.1.0 (baseline) Built [ 19.200s] (baseline) Parsing datafusion-physical-expr-common v55.1.0 (baseline) Parsed [ 0.018s] (baseline) Checking datafusion-physical-expr-common v55.1.0 -> v55.1.0 (no change; assume patch) Checked [ 0.272s] 223 checks: 223 pass, 31 skip Summary no semver update required Finished [ 39.480s] datafusion-physical-expr-common Building datafusion-physical-plan v55.1.0 (current) Built [ 30.636s] (current) Parsing datafusion-physical-plan v55.1.0 (current) Parsed [ 0.137s] (current) Building datafusion-physical-plan v55.1.0 (baseline) Built [ 31.081s] (baseline) Parsing datafusion-physical-plan v55.1.0 (baseline) Parsed [ 0.137s] (baseline) Checking datafusion-physical-plan v55.1.0 -> v55.1.0 (no change; assume patch) Checked [ 0.904s] 223 checks: 218 pass, 5 fail, 0 warn, 31 skip --- failure enum_now_doc_hidden: pub enum is now #[doc(hidden)] --- Description: A pub enum is now #[doc(hidden)], removing it from the crate's public API. ref: https://doc.rust-lang.org/rustdoc/write-documentation/the-doc-attribute.html#hidden impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.50.0/src/lints/enum_now_doc_hidden.ron Failed in: enum Map in file /home/runner/work/datafusion/datafusion/datafusion/physical-plan/src/joins/mod.rs:88 --- failure function_now_doc_hidden: pub function is now #[doc(hidden)] --- Description: A pub function is now #[doc(hidden)], removing it from the crate's public API. ref: https://doc.rust-lang.org/rustdoc/write-documentation/the-doc-attribute.html#hidden impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.50.0/src/lints/function_now_doc_hidden.ron Failed in: function get_best_fitting_window in file /home/runner/work/datafusion/datafusion/datafusion/physical-plan/src/windows/mod.rs:604 function concat_slices in file /home/runner/work/datafusion/datafusion/datafusion/physical-plan/src/aggregates/mod.rs:3263 --- failure inherent_method_now_doc_hidden: inherent method #[doc(hidden)] added --- Description: A method or associated fn is now #[doc(hidden)], removing it from the crate's public API. ref: https://doc.rust-lang.org/rustdoc/write-documentation/the-doc-attribute.html#hidden impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.50.0/src/lints/inherent_method_now_doc_hidden.ron Failed in: HashJoinExec::swap_inputs in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/0eb77530100399687f856d20ead4d21e95c75500/datafusion/physical-plan/src/joins/hash_join/exec.rs:1411 SymmetricHashJoinExec::check_if_order_information_available in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/0eb77530100399687f856d20ead4d21e95c75500/datafusion/physical-plan/src/joins/symmetric_hash_join.rs:339 AggregateExec::try_optimize_distinct_soft_limit in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/0eb77530100399687f856d20ead4d21e95c75500/datafusion/physical-plan/src/aggregates/mod.rs:1144 AggregateExec::with_new_aggr_exprs in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/0eb77530100399687f856d20ead4d21e95c75500/datafusion/physical-plan/src/aggregates/mod.rs:1169 CrossJoinExec::swap_inputs in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/0eb77530100399687f856d20ead4d21e95c75500/datafusion/physical-plan/src/joins/cross_join.rs:190 NestedLoopJoinExec::swap_inputs in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/0eb77530100399687f856d20ead4d21e95c75500/datafusion/physical-plan/src/joins/nested_loop_join.rs:479 --- failure struct_now_doc_hidden: pub struct is now #[doc(hidden)] --- Description: A pub struct is now #[doc(hidden)], removing it from the crate's public API. ref: https://doc.rust-lang.org/rustdoc/write-documentation/the-doc-attribute.html#hidden impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.50.0/src/lints/struct_now_doc_hidden.ron Failed in: struct HashExpr in file /home/runner/work/datafusion/datafusion/datafusion/physical-plan/src/joins/hash_join/partitioned_hash_eval.rs:90 struct SeededRandomState in file /home/runner/work/datafusion/datafusion/datafusion/physical-plan/src/joins/hash_join/partitioned_hash_eval.rs:50 --- failure trait_now_doc_hidden: pub trait is now #[doc(hidden)] --- Description: A pub trait is now #[doc(hidden)], removing it from the crate's public API. ref: https://doc.rust-lang.org/rustdoc/write-documentation/the-doc-attribute.html#hidden impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.50.0/src/lints/trait_now_doc_hidden.ron Failed in: trait JoinHashMapType in file /home/runner/work/datafusion/datafusion/datafusion/physical-plan/src/joins/join_hash_map.rs:110 Summary semver requires new major version: 5 major and 0 minor checks failed Finished [ 64.243s] datafusion-physical-plan ``` </details> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
