andygrove commented on PR #870: URL: https://github.com/apache/datafusion-comet/pull/870#issuecomment-2315797933
> I feel it should be good, considering DF already supports such casts. However I'm thinking if we should have a new struct field `allow_noncompat` or introduce new Spark Comet property? Spark Comet property probably is easier to drop when we dont need this logic anymore @comphead The new stuct field is populated via the config `spark.comet.cast.allowIncompatible`. Are you saying that we should pass this config explicitly in JNI rather than add the `allow_noncompat` flag to the protobuf and struct? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
